This repository was archived by the owner on Nov 26, 2025. It is now read-only.
fix: load auto-generated Swift import header correctly #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses Shopify#117, and gets the header to import correctly in modern versions of Xcode.
Contributor
Author
|
(Could someone reset my CLA status? I accidentally signed up with the wrong email, and now the CLA process won't let me sign the CLA) |
9 tasks
|
Same issue. Time to run patch-package. Hope this gets merged soon. Noticed this on version 4.1.0 Patch reference if you want to just copy paste this into your diff --git a/node_modules/@shopify/react-native-performance/ios/ReactNativePerformance/ReactNativePerformance.m b/node_modules/@shopify/react-native-performance/ios/ReactNativePerformance/ReactNativePerformance.m
index 4852113..dbb4bb5 100644
--- a/node_modules/@shopify/react-native-performance/ios/ReactNativePerformance/ReactNativePerformance.m
+++ b/node_modules/@shopify/react-native-performance/ios/ReactNativePerformance/ReactNativePerformance.m
@@ -1,5 +1,5 @@
#import "ReactNativePerformance.h"
-#import "ReactNativePerformance-Swift.h"
+#import <ReactNativePerformance/ReactNativePerformance-Swift.h>
static NSTimeInterval startupTimestamp = -1.0; |
|
@ElviraBurchik Are you planning on getting this released? Version 4.1.2 was released 3 years ago. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Project wasn't building successfully in Xcode. (See #117)
Description
Fixes (#117). The import location is not correct for modern versions of Xcode, which otherwise fail to find the auto-generated Swift header.
Test plan
yarn testChecklist